Implement bin sort with minsigma - #196
Merged
Merged
Conversation
Member
|
@y0z Could you review this PR? |
y0z
reviewed
Aug 18, 2026
Comment on lines
+240
to
+251
| @@ -209,6 +246,9 @@ impl NumericalDistributionBuilder for DefaultNumericalDistributionBuilder { | |||
| } | |||
| } | |||
|
|
|||
| // Sigma for prior | |||
| sigmas.push(adj_high - adj_low); | |||
|
|
|||
Member
There was a problem hiding this comment.
Moving sigmas.push here from above decreases sigmas.len() when computing minsigma (Using 2.0 + sigmas.len() may resolve the issue?).
(before)
...
sigmas.push(...)
let minsigma = (adj_high - adj_low) / (100.0_f64.min(1.0 + sigmas.len() as f64));
}(after)
...
let minsigma = (adj_high - adj_low) / (100.0_f64.min(1.0 + sigmas.len() as f64));
}
sigmas.push(...)
Member
Member
Author
There was a problem hiding this comment.
Thank you for pointing it out. I fixed the bug by using the original code as much as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sorting process for calculating bandwidth is consuming significant computation time. By distributing observations into bins of width
minsigma, I have simplified and accelerated this sorting operation.Benchmark
Details